-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to group by date only in chargeback #17893
Add possibility to group by date only in chargeback #17893
Conversation
@lpichler Cannot apply the following label because they are not recognized: improvement |
Checked commit lpichler@44841fa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@miq-bot add_label blocker |
@lpichler if this can be backported, can you add the gaprindashvili.yes and the fine/yes labels. |
@miq-bot add_label fine/yes, gaprindashvili/yes |
@lpichler Looks like we don't have the "group by tenants" spec in Fine branch. What do we need to do here? |
@simaishi ok, in that case I'll open PR for fine in a while. thanks |
Backported to Fine via #17909 |
…eback Add possibility to group by date only in chargeback (cherry picked from commit f1ee798) https://bugzilla.redhat.com/show_bug.cgi?id=1622631
Gaprindashvili backport details:
|
Backend part for ManageIQ/manageiq-ui-classic#4523
Option group by date and by vm had identical behaviour. This PR adds backend part to reach report grouped only per day(vm name is removed):
Links
@miq-bot add_label gaprindashvili/yes, chargeback, improvement
@miq-bot assign @gtanzillo